Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests and examples of Cₘ × C₂ 2BGA codes #392

Merged
merged 3 commits into from
Nov 5, 2024
Merged

add tests and examples of Cₘ × C₂ 2BGA codes #392

merged 3 commits into from
Nov 5, 2024
+154 −4

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 15, 2024 •
edited
Loading

This PR reproduces the entire Table 2 results of https://arxiv.org/pdf/2306.16400 using the Direct Product of Groups. The goal is twofold: demonstrate a new functionality via Direct Product of Abelian Groups using Hecke and crosscheck it via reproducing all the results from Table 2.

Table 2 whose results are reproduced:
Screenshot_select-area_20241015053059

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting. Please do not worry about or address older formatting issues -- keep your PR just focused on your planned contribution.

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (be50f9c) to head (b4f0977).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files          70       70           
  Lines        4410     4410           
=======================================
  Hits         3663     3663           
  Misses        747      747

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Oct 15, 2024

I think the PR is good to go @Krastanov

@royess, just pinging you for reference

@Fe-r-oz Fe-r-oz changed the title Direct Products of Groups via Hecke for 2BGA codes to reproduce Table 2 results by H.K.Lin et al. Direct Producs of Groups Abelian Cₘ × Cₙ via Hecke for 2BGA codes Oct 18, 2024
@Fe-r-oz Fe-r-oz changed the title Direct Producs of Groups Abelian Cₘ × Cₙ via Hecke for 2BGA codes Direct Products of Groups Abelian Cₘ × Cₙ via Hecke for 2BGA codes Oct 18, 2024
This was referenced Oct 18, 2024
Open
Draft
@Fe-r-oz Fe-r-oz changed the title Direct Products of Groups Abelian Cₘ × Cₙ via Hecke for 2BGA codes Direct Products of Groups Abelian Cₘ × C₂ via Hecke for 2BGA code Oct 19, 2024
@Fe-r-oz Fe-r-oz changed the title Direct Products of Groups Abelian Cₘ × C₂ via Hecke for 2BGA code Direct Product of Groups Abelian Cₘ × C₂ via Hecke for 2BGA code Oct 19, 2024
@Fe-r-oz Fe-r-oz changed the title Direct Product of Groups Abelian Cₘ × C₂ via Hecke for 2BGA code Direct Product of Abelian Groups Cₘ × C₂ via Hecke for 2BGA code Oct 19, 2024
@Krastanov Krastanov added the Skip-Changelog label for control of CI: skips the changelog check label Nov 5, 2024
@Krastanov Krastanov changed the title Direct Product of Abelian Groups Cₘ × C₂ via Hecke for 2BGA code add tests and examples of Cₘ × C₂ 2BGA codes Nov 5, 2024
@Krastanov
Copy link
Member

wonderful! These additions are also now put on the TODO list for the ECC benchmark wiki

@Krastanov Krastanov merged commit 40924b8 into QuantumSavory:master Nov 5, 2024
14 of 17 checks passed
@Fe-r-oz Fe-r-oz deleted the 2bgalintable2 branch November 5, 2024 08:05
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Nov 5, 2024

Thank you, I will submit the TODO today, making this much more polished.

@Fe-r-oz Fe-r-oz mentioned this pull request Nov 5, 2024
Merged
@Fe-r-oz Fe-r-oz mentioned this pull request Dec 5, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Skip-Changelog label for control of CI: skips the changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fe-r-oz @Krastanov